Skip to content

feat(contracts): adding the new availableExpectations field (#304)#306

Merged
SamuelHassine merged 4 commits into
mainfrom
feat/304-add-available-expectations
Jul 18, 2026
Merged

feat(contracts): adding the new availableExpectations field (#304)#306
SamuelHassine merged 4 commits into
mainfrom
feat/304-add-available-expectations

Conversation

@guzmud

@guzmud guzmud commented Jul 15, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Adding new field availableExpectations to ContractExpectations

Testing Instructions

  1. Need to be tested through an updated injector rather than as a stand-alone

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

Copilot AI review requested due to automatic review settings July 15, 2026 13:28
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Jul 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Python contract configuration models to align with the injector contract change described in #304 by adding support for an availableExpectations list alongside predefinedExpectations on the expectations contract field.

Changes:

  • Add availableExpectations: List[Expectation] to ContractExpectations in the contracts config model.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyoaev/contracts/contract_config.py Outdated
@SamuelHassine
SamuelHassine merged commit 3ca50c3 into main Jul 18, 2026
13 checks passed
@SamuelHassine
SamuelHassine deleted the feat/304-add-available-expectations branch July 18, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(contracts): DRY refactoring of availableExpectations versus predefinedExpectations feat(contracts): add a availableExpectations field

4 participants